Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to keep display on when fullscreen #4

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Option to keep display on when fullscreen #4

merged 2 commits into from
Oct 7, 2024

Conversation

Silic0nS0ldier
Copy link
Contributor

This PR adds an argument keepDisplayOn to enterFullscreen.

  • On Android, the fullscreen activity will set the FLAG_KEEP_SCREEN_ON flag.
  • On iOS, the idle timer is disabled (UIApplication.shared.isIdleTimerDisabled = false)

The example app has been updated so that;

  • The "keep display on" behaviour can be toggled.
  • Individual videos can be more easily identified (previously it was a wall of black, save for the currently playing video).

Android has been tested (Pixel 8), iOS has not.

The intent behind this change is to keep the display on when viewing videos in fullscreen within the Bluesky mobile app.

@haileyok
Copy link
Collaborator

haileyok commented Oct 7, 2024

Thank you @Silic0nS0ldier! Going to get through this today, really appreciate you digging through here and getting this in 🙏

haileyok
haileyok approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you so much!

@haileyok haileyok merged commit 886cd75 into bluesky-social:main Oct 7, 2024
@haileyok haileyok mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyok haileyok haileyok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Silic0nS0ldier @haileyok